Hello brought my first boat and need help motor cranks but no spark its a johnson 90hp any help will be much appreciated

alright will get the engine full serviced don't want to be out at sea and get stuck and yeah il get them to check all those as well thanks for help

Was it running when you brought it?? If so as smudge says kill switch check if was running on purchase give previous owner a call as too possible causes

Yes the motor was running when purchased, I had to replace steering cable and also the starter motor, ever since we installed starter motor we have had this problem with it cranking but no spark.

Do you know the starting routine? It's been years since I've used a VRO (I presume thats what it is?) From memory its pretty standard. Pump up the bulb. Turn on the key, push it in and count to three before twisting the key to engage starter motor. It sounds to me like you aren't pushing in the key before starting.

I had a 90hp Johnson, if I wasn't pushing in the key at the same time as starting it would never fire.

Just to explain the key push thing.  Pumping the bulb pressurises the fuel line. The fuel line has a solenoid which goes straight to the motor - it bypasses the carburettor pretty much. When the key is pushed, the solenoid energises allowing a shot of fuel into the crankcase so it is an enrichener rather than a choke but both serve a similar purpose. Steps is right that the fuel bulb must be mounted correctly and must also be in good condition of course.